Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small code refactor #6263

Merged
merged 5 commits into from
Jul 13, 2024
Merged

Small code refactor #6263

merged 5 commits into from
Jul 13, 2024

Conversation

ylmin
Copy link
Contributor

@ylmin ylmin commented Jul 11, 2024

Description

  • Optimize code

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@ylmin ylmin requested a review from a team as a code owner July 11, 2024 16:50
IGI-111
IGI-111 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@IGI-111 IGI-111 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however please write better descriptions of your changes next time, even if they are minor.

@IGI-111 IGI-111 requested a review from a team July 12, 2024 10:22
@IGI-111 IGI-111 changed the title refactor: Optimize code Small code refactor Jul 12, 2024
@ylmin
Copy link
Contributor Author

ylmin commented Jul 12, 2024

LGTM, however please write better descriptions of your changes next time, even if they are minor.
Ok

@JoshuaBatty JoshuaBatty enabled auto-merge (squash) July 13, 2024 23:32
@JoshuaBatty JoshuaBatty merged commit a901028 into FuelLabs:master Jul 13, 2024
37 checks passed
esdrubal pushed a commit that referenced this pull request Aug 13, 2024
@ylmin @IGI-111
@JoshuaBatty @esdrubal
Small code refactor (#6263)
dbae03a 
## Description
- Optimize code

## Checklist

- [ ] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.

---------

Co-authored-by: IGI-111 <igi-111@protonmail.com>
Co-authored-by: Joshua Batty <joshpbatty@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IGI-111 IGI-111 IGI-111 approved these changes

@tritao tritao tritao approved these changes

Assignees

@ylmin ylmin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ylmin @tritao @IGI-111 @JoshuaBatty